proper init of publick_key

verify_transaction proper value
add safe copy
2020-10-22 14:55:37 +00:00 · 2020-10-22 12:02:46 +00:00 · 2020-10-20 06:16:17 +00:00 · 2020-10-18 23:14:11 +02:00 · 2020-10-18 23:12:39 +02:00 · 2020-10-18 23:11:26 +02:00
68 changed files with 136 additions and 121 deletions
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@ -18,7 +18,7 @@ build:
    - rm -rf build
    - mkdir build
    - cd build
-    - cmake ..
+    - cmake -DCMAKE_BUILD_TYPE=Release ..
    - make -j$(nproc)
  artifacts:
    untracked: true
--- a/libraries/app/api.cpp
+++ b/libraries/app/api.cpp
@ -38,7 +38,6 @@
 #include <graphene/chain/tournament_object.hpp>
 #include <fc/crypto/hex.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/rpc/api_connection.hpp>
 #include <fc/thread/future.hpp>
--- a/libraries/app/application.cpp
+++ b/libraries/app/application.cpp
@ -37,8 +37,6 @@
 #include <graphene/utilities/key_conversion.hpp>
 #include <graphene/chain/worker_evaluator.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/io/fstream.hpp>
 #include <fc/rpc/api_connection.hpp>
 #include <fc/rpc/websocket_api.hpp>
@ -80,7 +78,7 @@ namespace detail {
      auto nathan_key = fc::ecc::private_key::regenerate(fc::sha256::hash(string("nathan")));
      dlog("Allocating all stake to ${key}", ("key", utilities::key_to_wif(nathan_key)));
      genesis_state_type initial_state;
-      initial_state.initial_parameters.current_fees = fee_schedule::get_default();//->set_all_fees(GRAPHENE_BLOCKCHAIN_PRECISION);
+      initial_state.initial_parameters.current_fees = std::make_shared<fee_schedule>(fee_schedule::get_default());
      initial_state.initial_active_witnesses = GRAPHENE_DEFAULT_MIN_WITNESS_COUNT;
      initial_state.initial_timestamp = time_point_sec(time_point::now().sec_since_epoch() /
            initial_state.initial_parameters.block_interval *
--- a/libraries/app/database_api.cpp
+++ b/libraries/app/database_api.cpp
@ -30,7 +30,6 @@
 #include <graphene/chain/pts_address.hpp>
 #include <fc/bloom_filter.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/crypto/hex.hpp>
 #include <fc/rpc/api_connection.hpp>
--- a/libraries/chain/CMakeLists.txt
+++ b/libraries/chain/CMakeLists.txt
@ -43,6 +43,7 @@ add_library( graphene_chain
             protocol/assert.cpp
             protocol/account.cpp
             protocol/transfer.cpp
             protocol/chain_parameters.cpp
             protocol/committee_member.cpp
             protocol/witness.cpp
             protocol/market.cpp
--- a/libraries/chain/account_evaluator.cpp
+++ b/libraries/chain/account_evaluator.cpp
@ -22,8 +22,6 @@
 * THE SOFTWARE.
 */
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/chain/account_evaluator.hpp>
 #include <graphene/chain/buyback.hpp>
 #include <graphene/chain/buyback_object.hpp>
--- a/libraries/chain/betting_market_evaluator.cpp
+++ b/libraries/chain/betting_market_evaluator.cpp
@ -22,7 +22,6 @@
 * THE SOFTWARE.
 */
 #define DEFAULT_LOGGER "betting"
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/chain/betting_market_evaluator.hpp>
 #include <graphene/chain/betting_market_object.hpp>
--- a/libraries/chain/block_database.cpp
+++ b/libraries/chain/block_database.cpp
@ -24,7 +24,6 @@
 #include <graphene/chain/block_database.hpp>
 #include <graphene/chain/protocol/fee_schedule.hpp>
 #include <fc/io/raw.hpp>
 #include <fc/smart_ref_impl.hpp>
 namespace graphene { namespace chain {
--- a/libraries/chain/committee_member_evaluator.cpp
+++ b/libraries/chain/committee_member_evaluator.cpp
@ -30,8 +30,6 @@
 #include <graphene/chain/protocol/vote.hpp>
 #include <graphene/chain/transaction_evaluation_state.hpp>
 #include <fc/smart_ref_impl.hpp>
 namespace graphene { namespace chain {
 void_result committee_member_create_evaluator::do_evaluate( const committee_member_create_operation& op )
--- a/libraries/chain/confidential_evaluator.cpp
+++ b/libraries/chain/confidential_evaluator.cpp
@ -29,8 +29,6 @@
 #include <graphene/chain/fba_accumulator_id.hpp>
 #include <graphene/chain/hardfork.hpp>
 #include <fc/smart_ref_impl.hpp>
 namespace graphene { namespace chain {
 void_result transfer_to_blind_evaluator::do_evaluate( const transfer_to_blind_operation& o )
--- a/libraries/chain/database.cpp
+++ b/libraries/chain/database.cpp
@ -21,7 +21,6 @@
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */
 #include <fc/smart_ref_impl.hpp>
 #include "db_balance.cpp"
 #include "db_bet.cpp"
 #include "db_block.cpp"
--- a/libraries/chain/db_block.cpp
+++ b/libraries/chain/db_block.cpp
@ -42,7 +42,6 @@
 #include <graphene/chain/witness_schedule_object.hpp>
 #include <fc/crypto/digest.hpp>
 #include <fc/smart_ref_impl.hpp>
 namespace {
--- a/libraries/chain/db_getter.cpp
+++ b/libraries/chain/db_getter.cpp
@ -34,8 +34,6 @@
 #include <graphene/chain/son_object.hpp>
 #include <graphene/chain/son_proposal_object.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <ctime>
 #include <algorithm>
@ -68,7 +66,7 @@ const dynamic_global_property_object& database::get_dynamic_global_properties()
 const fee_schedule&  database::current_fee_schedule()const
 {
-   return get_global_properties().parameters.current_fees;
+   return std::ref( *get_global_properties().parameters.current_fees );
 }
 time_point_sec database::head_block_time()const
--- a/libraries/chain/db_init.cpp
+++ b/libraries/chain/db_init.cpp
@ -103,7 +103,6 @@
 #include <graphene/chain/protocol/fee_schedule.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/uint128.hpp>
 #include <fc/crypto/digest.hpp>
--- a/libraries/chain/db_maint.cpp
+++ b/libraries/chain/db_maint.cpp
@ -24,7 +24,6 @@
 #include <boost/multiprecision/integer.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/uint128.hpp>
 #include <graphene/chain/database.hpp>
--- a/libraries/chain/fork_database.cpp
+++ b/libraries/chain/fork_database.cpp
@ -24,7 +24,6 @@
 #include <graphene/chain/fork_database.hpp>
 #include <graphene/chain/exceptions.hpp>
 #include <graphene/chain/protocol/fee_schedule.hpp>
 #include <fc/smart_ref_impl.hpp>
 namespace graphene { namespace chain {
 fork_database::fork_database()
--- a/libraries/chain/genesis_state.cpp
+++ b/libraries/chain/genesis_state.cpp
@ -25,7 +25,6 @@
 #include <graphene/chain/genesis_state.hpp>
 // these are required to serialize a genesis_state
 #include <fc/smart_ref_impl.hpp>   // required for gcc in release mode
 #include <graphene/chain/protocol/fee_schedule.hpp>
 namespace graphene { namespace chain {
--- a/libraries/chain/hardfork.d/SON.hf
+++ b/libraries/chain/hardfork.d/SON.hf
@ -1,5 +1,7 @@
-// SON HARDFORK Tuesday, October 20, 2020 00:00:00 UTC
+// SON HARDFORK Wednesday, January 1, 2020 12:00:00 AM - 1577836800
 // SON HARDFORK Monday, March 30, 2020 3:00:00 PM - 1585573200
 // SON HARDFORK Monday, September 21, 2020 1:43:11 PM - 1600695791
 #ifndef HARDFORK_SON_TIME
 #include <ctime>
-#define HARDFORK_SON_TIME (fc::time_point_sec( 1603152000 ))
+#define HARDFORK_SON_TIME (fc::time_point_sec( 1585573200 ))
 #endif
--- a/libraries/chain/include/graphene/chain/protocol/chain_parameters.hpp
+++ b/libraries/chain/include/graphene/chain/protocol/chain_parameters.hpp
@ -22,10 +22,10 @@
 * THE SOFTWARE.
 */
 #pragma once
 #include <memory>
 #include <graphene/chain/protocol/base.hpp>
 #include <graphene/chain/protocol/ext.hpp>
 #include <graphene/chain/protocol/types.hpp>
 #include <fc/smart_ref_fwd.hpp>
 #include <graphene/chain/hardfork.hpp>
 #include <../hardfork.d/GPOS.hf>
@ -72,8 +72,13 @@ namespace graphene { namespace chain {
   struct chain_parameters
   {
      chain_parameters();
      chain_parameters(const chain_parameters& other);
      chain_parameters(chain_parameters&& other);
      chain_parameters& operator=(const chain_parameters& other);
      chain_parameters& operator=(chain_parameters&& other);
      /** using a smart ref breaks the circular dependency created between operations and the fee schedule */
-      smart_ref<fee_schedule> current_fees;                       ///< current schedule of fees
+      std::shared_ptr<fee_schedule> current_fees;                       ///< current schedule of fees
      uint8_t                 block_interval                      = GRAPHENE_DEFAULT_BLOCK_INTERVAL; ///< interval in seconds between blocks
      uint32_t                maintenance_interval                = GRAPHENE_DEFAULT_MAINTENANCE_INTERVAL; ///< interval in sections between blockchain maintenance events
      uint8_t                 maintenance_skip_slots              = GRAPHENE_DEFAULT_MAINTENANCE_SKIP_SLOTS; ///< number of block_intervals to skip at maintenance time
@ -207,6 +212,8 @@ namespace graphene { namespace chain {
      inline uint16_t maximum_son_count()const {
         return extensions.value.maximum_son_count.valid() ? *extensions.value.maximum_son_count : GRAPHENE_DEFAULT_MAX_SONS;
      }
      private:
      static void safe_copy(chain_parameters& to, const chain_parameters& from);
   };
 } }  // graphene::chain
--- a/libraries/chain/include/graphene/chain/protocol/fee_schedule.hpp
+++ b/libraries/chain/include/graphene/chain/protocol/fee_schedule.hpp
@ -22,7 +22,6 @@
 * THE SOFTWARE.
 */
 #pragma once
 #include <fc/smart_ref_fwd.hpp>
 #include <graphene/chain/protocol/operations.hpp>
 namespace graphene { namespace chain {
@ -84,6 +83,10 @@ namespace graphene { namespace chain {
 } } // graphene::chain
 namespace fc {
   template<> struct get_typename<std::shared_ptr<graphene::chain::fee_schedule>> { static const char* name() { return "shared_ptr<fee_schedule>"; } };
 }
 FC_REFLECT_TYPENAME( graphene::chain::fee_parameters )
 FC_REFLECT( graphene::chain::fee_schedule, (parameters)(scale) )
--- a/libraries/chain/include/graphene/chain/protocol/types.hpp
+++ b/libraries/chain/include/graphene/chain/protocol/types.hpp
@ -38,7 +38,6 @@
 #include <fc/io/raw_fwd.hpp>
 #include <fc/uint128.hpp>
 #include <fc/static_variant.hpp>
 #include <fc/smart_ref_fwd.hpp>
 #include <memory>
 #include <vector>
--- a/libraries/chain/market_evaluator.cpp
+++ b/libraries/chain/market_evaluator.cpp
@ -35,7 +35,6 @@
 #include <graphene/chain/protocol/market.hpp>
 #include <fc/uint128.hpp>
 #include <fc/smart_ref_impl.hpp>
 namespace graphene { namespace chain {
 void_result limit_order_create_evaluator::do_evaluate(const limit_order_create_operation& op)
--- a/libraries/chain/proposal_evaluator.cpp
+++ b/libraries/chain/proposal_evaluator.cpp
@ -32,8 +32,6 @@
 #include <graphene/chain/exceptions.hpp>
 #include <graphene/chain/hardfork.hpp>
 #include <fc/smart_ref_impl.hpp>
 namespace graphene { namespace chain {
 struct proposal_operation_hardfork_visitor
--- a/libraries/chain/protocol/chain_parameters.cpp
+++ b/libraries/chain/protocol/chain_parameters.cpp
@ -0,0 +1,92 @@
 #include <graphene/chain/protocol/chain_parameters.hpp>
 #include <graphene/chain/protocol/fee_schedule.hpp>
 namespace graphene { namespace chain {
   chain_parameters::chain_parameters() {
       current_fees = std::make_shared<fee_schedule>();
   }
   // copy constructor
   chain_parameters::chain_parameters(const chain_parameters& other)
   {
      current_fees = std::make_shared<fee_schedule>(*other.current_fees);
      safe_copy(*this, other);
   }
   // copy assignment
   chain_parameters& chain_parameters::operator=(const chain_parameters& other)
   {
      if (&other != this)
      {
         current_fees = std::make_shared<fee_schedule>(*other.current_fees);
         safe_copy(*this, other);
      }
      return *this;
   }
   // copies the easy stuff
   void chain_parameters::safe_copy(chain_parameters& to, const chain_parameters& from)
   {
      to.block_interval = from.block_interval;
      to.maintenance_interval = from.maintenance_interval;
      to.maintenance_skip_slots = from.maintenance_skip_slots;
      to.committee_proposal_review_period = from.committee_proposal_review_period;
      to.maximum_transaction_size = from.maximum_transaction_size;
      to.maximum_block_size = from.maximum_block_size;
      to.maximum_time_until_expiration = from.maximum_time_until_expiration;
      to.maximum_proposal_lifetime = from.maximum_proposal_lifetime;
      to.maximum_asset_whitelist_authorities = from.maximum_asset_whitelist_authorities;
      to.maximum_asset_feed_publishers = from.maximum_asset_feed_publishers;
      to.maximum_witness_count = from.maximum_witness_count;
      to.maximum_committee_count = from.maximum_committee_count;
      to.maximum_authority_membership = from.maximum_authority_membership;
      to.reserve_percent_of_fee = from.reserve_percent_of_fee;
      to.network_percent_of_fee = from.network_percent_of_fee;
      to.lifetime_referrer_percent_of_fee = from.lifetime_referrer_percent_of_fee;
      to.cashback_vesting_period_seconds = from.cashback_vesting_period_seconds;
      to.cashback_vesting_threshold = from.cashback_vesting_threshold;
      to.count_non_member_votes = from.count_non_member_votes;
      to.allow_non_member_whitelists = from.allow_non_member_whitelists;
      to.witness_pay_per_block = from.witness_pay_per_block;
      to.witness_pay_vesting_seconds = from.witness_pay_vesting_seconds;
      to.worker_budget_per_day = from.worker_budget_per_day;
      to.max_predicate_opcode = from.max_predicate_opcode;
      to.fee_liquidation_threshold = from.fee_liquidation_threshold;
      to.accounts_per_fee_scale = from.accounts_per_fee_scale;
      to.account_fee_scale_bitshifts = from.account_fee_scale_bitshifts;
      to.max_authority_depth = from.max_authority_depth;
      to.witness_schedule_algorithm= from.witness_schedule_algorithm;
      to.min_round_delay = from.min_round_delay;
      to.max_round_delay = from.max_round_delay;
      to.min_time_per_commit_move = from.min_time_per_commit_move;
      to.max_time_per_commit_move = from.max_time_per_commit_move;
      to.min_time_per_reveal_move = from.min_time_per_reveal_move;
      to.max_time_per_reveal_move = from.max_time_per_reveal_move;
      to.rake_fee_percentage = from.rake_fee_percentage;
      to.maximum_registration_deadline = from.maximum_registration_deadline;
      to.maximum_players_in_tournament = from.maximum_players_in_tournament;
      to.maximum_tournament_whitelist_length = from.maximum_tournament_whitelist_length;
      to.maximum_tournament_start_time_in_future= from.maximum_tournament_start_time_in_future;
      to.maximum_tournament_start_delay = from.maximum_tournament_start_delay;
      to.maximum_tournament_number_of_wins = from.maximum_tournament_number_of_wins;
      to.extensions = from.extensions;
   }
   // move constructor
   chain_parameters::chain_parameters(chain_parameters&& other)
   {
      current_fees = std::move(other.current_fees);
      safe_copy(*this, other);
   }
   // move assignment
   chain_parameters& chain_parameters::operator=(chain_parameters&& other)
   {
      if (&other != this)
      {
         current_fees = std::move(other.current_fees);
         safe_copy(*this, other);
      }
      return *this;
   }
 }}
--- a/libraries/chain/protocol/committee_member.cpp
+++ b/libraries/chain/protocol/committee_member.cpp
@ -21,7 +21,6 @@
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/chain/protocol/fee_schedule.hpp>
 #include <graphene/chain/protocol/committee_member.hpp>
--- a/libraries/chain/protocol/fee_schedule.cpp
+++ b/libraries/chain/protocol/fee_schedule.cpp
@ -23,17 +23,6 @@
 */
 #include <algorithm>
 #include <graphene/chain/protocol/fee_schedule.hpp>
 #include <fc/smart_ref_impl.hpp>
 namespace fc
 {
   // explicitly instantiate the smart_ref, gcc fails to instantiate it in some release builds
   //template graphene::chain::fee_schedule& smart_ref<graphene::chain::fee_schedule>::operator=(smart_ref<graphene::chain::fee_schedule>&&);
   //template graphene::chain::fee_schedule& smart_ref<graphene::chain::fee_schedule>::operator=(U&&);
   //template graphene::chain::fee_schedule& smart_ref<graphene::chain::fee_schedule>::operator=(const smart_ref&);
   //template smart_ref<graphene::chain::fee_schedule>::smart_ref();
   //template const graphene::chain::fee_schedule& smart_ref<graphene::chain::fee_schedule>::operator*() const;
 }
 #include <fc/io/raw.hpp>
@ -41,10 +30,6 @@ namespace fc
 namespace graphene { namespace chain {
   typedef fc::smart_ref<fee_schedule> smart_fee_schedule;
   static smart_fee_schedule tmp;
   fee_schedule::fee_schedule()
   {
   }
--- a/libraries/chain/protocol/operations.cpp
+++ b/libraries/chain/protocol/operations.cpp
@ -21,7 +21,6 @@
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/chain/protocol/operations.hpp>
 #include <graphene/chain/protocol/fee_schedule.hpp>
 #include <fc/io/raw.hpp>
--- a/libraries/chain/protocol/proposal.cpp
+++ b/libraries/chain/protocol/proposal.cpp
@ -23,7 +23,6 @@
 */
 #include <graphene/chain/protocol/operations.hpp>
 #include <graphene/chain/protocol/fee_schedule.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/io/raw.hpp>
--- a/libraries/chain/protocol/small_ops.cpp
+++ b/libraries/chain/protocol/small_ops.cpp
@ -22,7 +22,6 @@
 * THE SOFTWARE.
 */
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/chain/protocol/balance.hpp>
 #include <graphene/chain/protocol/buyback.hpp>
 #include <graphene/chain/protocol/fba.hpp>
--- a/libraries/chain/protocol/transaction.cpp
+++ b/libraries/chain/protocol/transaction.cpp
@ -25,7 +25,6 @@
 #include <graphene/chain/protocol/fee_schedule.hpp>
 #include <fc/io/raw.hpp>
 #include <fc/bitutil.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <algorithm>
 #include <fc/io/raw.hpp>
@ -106,6 +105,7 @@ void transaction::get_required_authorities( flat_set<account_id_type>& active,
 const flat_set<public_key_type> empty_keyset;
 struct sign_state
 {
@ -231,7 +231,7 @@ struct sign_state
      sign_state( const flat_set<public_key_type>& sigs,
                  const std::function<const authority*(account_id_type)>& a,
-                  const flat_set<public_key_type>& keys = flat_set<public_key_type>() )
+                  const flat_set<public_key_type>& keys = empty_keyset )
      :get_active(a),available_keys(keys)
      {
         for( const auto& key : sigs )
@ -446,7 +446,7 @@ void signed_transaction::verify_authority(
   bool ignore_custom_operation_required_auths,
   uint32_t max_recursion )const
 { try {
-   graphene::chain::verify_authority( operations, get_signature_keys( chain_id ), get_active, get_owner, get_custom, max_recursion );
+   graphene::chain::verify_authority( operations, get_signature_keys( chain_id ), get_active, get_owner, get_custom, ignore_custom_operation_required_auths, max_recursion );
 } FC_CAPTURE_AND_RETHROW( (*this) ) }
 } } // graphene::chain
--- a/libraries/chain/small_objects.cpp
+++ b/libraries/chain/small_objects.cpp
@ -44,7 +44,6 @@
 #include <graphene/chain/worker_object.hpp>
 #include <fc/io/raw.hpp>
 #include <fc/smart_ref_impl.hpp>
 GRAPHENE_EXTERNAL_SERIALIZATION( /*not extern*/, graphene::chain::balance_object )
 GRAPHENE_EXTERNAL_SERIALIZATION( /*not extern*/, graphene::chain::block_summary_object )
--- a/libraries/db/include/graphene/db/generic_index.hpp
+++ b/libraries/db/include/graphene/db/generic_index.hpp
@ -73,7 +73,7 @@ namespace graphene { namespace chain {
                                       [&m, &exc](ObjectType& o) mutable {
                                          try {
                                             m(o);
-                                          } catch (fc::exception e) {
+                                          } catch (fc::exception& e) {
                                             exc = std::current_exception();
                                             elog("Exception while modifying object: ${e} -- object may be corrupted",
                                                  ("e", e));
--- a/libraries/egenesis/embed_genesis.cpp
+++ b/libraries/egenesis/embed_genesis.cpp
@ -30,7 +30,6 @@
 #include <boost/algorithm/string.hpp>
 #include <fc/filesystem.hpp>
 #include <fc/smart_ref_impl.hpp>   // required for gcc in release mode
 #include <fc/string.hpp>
 #include <fc/io/fstream.hpp>
 #include <fc/io/json.hpp>
--- a/libraries/net/node.cpp
+++ b/libraries/net/node.cpp
@ -70,7 +70,6 @@
 #include <fc/crypto/rand.hpp>
 #include <fc/network/rate_limiting.hpp>
 #include <fc/network/ip.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/net/node.hpp>
 #include <graphene/net/peer_database.hpp>
--- a/libraries/plugins/account_history/account_history_plugin.cpp
+++ b/libraries/plugins/account_history/account_history_plugin.cpp
@ -35,7 +35,6 @@
 #include <graphene/chain/transaction_evaluation_state.hpp>
 #include <graphene/chain/hardfork.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/thread/thread.hpp>
 namespace graphene { namespace account_history {
--- a/libraries/plugins/accounts_list/accounts_list_plugin.cpp
+++ b/libraries/plugins/accounts_list/accounts_list_plugin.cpp
@ -34,7 +34,6 @@
 #include <graphene/chain/operation_history_object.hpp>
 #include <graphene/chain/transaction_evaluation_state.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/thread/thread.hpp>
 namespace graphene { namespace accounts_list {
--- a/libraries/plugins/affiliate_stats/affiliate_stats_api.cpp
+++ b/libraries/plugins/affiliate_stats/affiliate_stats_api.cpp
@ -24,7 +24,6 @@
 #include <fc/optional.hpp>
 #include <fc/variant_object.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/app/application.hpp>
--- a/libraries/plugins/affiliate_stats/affiliate_stats_plugin.cpp
+++ b/libraries/plugins/affiliate_stats/affiliate_stats_plugin.cpp
@ -35,7 +35,6 @@
 #include <graphene/chain/operation_history_object.hpp>
 #include <graphene/chain/transaction_evaluation_state.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/thread/thread.hpp>
 namespace graphene { namespace affiliate_stats {
--- a/libraries/plugins/bookie/bookie_api.cpp
+++ b/libraries/plugins/bookie/bookie_api.cpp
@ -24,7 +24,6 @@
 #include <fc/filesystem.hpp>
 #include <fc/optional.hpp>
 #include <fc/variant_object.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/app/application.hpp>
--- a/libraries/plugins/bookie/bookie_plugin.cpp
+++ b/libraries/plugins/bookie/bookie_plugin.cpp
@ -36,7 +36,6 @@
 #include <boost/algorithm/string/case_conv.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/thread/thread.hpp>
 #include <boost/polymorphic_cast.hpp>
--- a/libraries/plugins/debug_witness/debug_api.cpp
+++ b/libraries/plugins/debug_witness/debug_api.cpp
@ -2,7 +2,6 @@
 #include <fc/filesystem.hpp>
 #include <fc/optional.hpp>
 #include <fc/variant_object.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/app/application.hpp>
--- a/libraries/plugins/debug_witness/debug_witness.cpp
+++ b/libraries/plugins/debug_witness/debug_witness.cpp
@ -28,7 +28,6 @@
 #include <graphene/utilities/key_conversion.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/thread/thread.hpp>
 #include <iostream>
--- a/libraries/plugins/delayed_node/delayed_node_plugin.cpp
+++ b/libraries/plugins/delayed_node/delayed_node_plugin.cpp
@ -30,8 +30,6 @@
 #include <fc/network/http/websocket.hpp>
 #include <fc/rpc/websocket_api.hpp>
 #include <fc/api.hpp>
 #include <fc/smart_ref_impl.hpp>
 namespace graphene { namespace delayed_node {
 namespace bpo = boost::program_options;
--- a/libraries/plugins/es_objects/es_objects.cpp
+++ b/libraries/plugins/es_objects/es_objects.cpp
@ -24,8 +24,6 @@
 #include <graphene/es_objects/es_objects.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <curl/curl.h>
 #include <graphene/chain/proposal_object.hpp>
 #include <graphene/chain/balance_object.hpp>
--- a/libraries/plugins/generate_genesis/generate_genesis.cpp
+++ b/libraries/plugins/generate_genesis/generate_genesis.cpp
@ -29,7 +29,6 @@
 #include <graphene/utilities/key_conversion.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/thread/thread.hpp>
 #include <graphene/chain/market_object.hpp>
--- a/libraries/plugins/generate_uia_sharedrop_genesis/generate_uia_sharedrop_genesis.cpp
+++ b/libraries/plugins/generate_uia_sharedrop_genesis/generate_uia_sharedrop_genesis.cpp
@ -29,7 +29,6 @@
 #include <graphene/utilities/key_conversion.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/thread/thread.hpp>
 #include <graphene/chain/market_object.hpp>
--- a/libraries/plugins/market_history/market_history_plugin.cpp
+++ b/libraries/plugins/market_history/market_history_plugin.cpp
@ -34,7 +34,6 @@
 #include <graphene/chain/protocol/fee_schedule.hpp>
 #include <fc/thread/thread.hpp>
 #include <fc/smart_ref_impl.hpp>
 namespace graphene { namespace market_history {
--- a/libraries/plugins/peerplays_sidechain/peerplays_sidechain_plugin.cpp
+++ b/libraries/plugins/peerplays_sidechain/peerplays_sidechain_plugin.cpp
@ -5,8 +5,6 @@
 #include <boost/range/algorithm_ext/insert.hpp>
 #include <fc/log/logger.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/chain/proposal_object.hpp>
 #include <graphene/chain/protocol/transfer.hpp>
 #include <graphene/chain/sidechain_address_object.hpp>
--- a/libraries/plugins/peerplays_sidechain/sidechain_net_handler.cpp
+++ b/libraries/plugins/peerplays_sidechain/sidechain_net_handler.cpp
@ -1,7 +1,6 @@
 #include <graphene/peerplays_sidechain/sidechain_net_handler.hpp>
 #include <fc/log/logger.hpp>
 #include <fc/smart_ref_fwd.hpp>
 #include <graphene/chain/chain_property_object.hpp>
 #include <graphene/chain/proposal_object.hpp>
--- a/libraries/plugins/peerplays_sidechain/sidechain_net_handler_peerplays.cpp
+++ b/libraries/plugins/peerplays_sidechain/sidechain_net_handler_peerplays.cpp
@ -11,7 +11,6 @@
 #include <fc/crypto/hex.hpp>
 #include <fc/log/logger.hpp>
 #include <fc/network/ip.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/chain/account_object.hpp>
 #include <graphene/chain/protocol/fee_schedule.hpp>
--- a/libraries/plugins/witness/witness.cpp
+++ b/libraries/plugins/witness/witness.cpp
@ -30,7 +30,6 @@
 #include <boost/range/algorithm_ext/insert.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/thread/thread.hpp>
 #include <iostream>
--- a/libraries/wallet/wallet.cpp
+++ b/libraries/wallet/wallet.cpp
@ -84,7 +84,6 @@
 #include <graphene/wallet/api_documentation.hpp>
 #include <graphene/wallet/reflect_util.hpp>
 #include <graphene/debug_witness/debug_api.hpp>
 #include <fc/smart_ref_impl.hpp>
 #ifndef WIN32
 # include <sys/types.h>
@ -662,10 +661,10 @@ public:
      return ob.template as<T>( GRAPHENE_MAX_NESTED_OBJECTS );
   }
-   void set_operation_fees( signed_transaction& tx, const fee_schedule& s  )
+   void set_operation_fees( signed_transaction& tx, std::shared_ptr<fee_schedule> s  )
   {
      for( auto& op : tx.operations )
-         s.set_fee(op);
+         s->set_fee(op);
   }
   variant info() const
@ -1307,8 +1306,7 @@ public:
      tx.operations.push_back( account_create_op );
-      auto current_fees = _remote_db->get_global_properties().parameters.current_fees;
+      set_operation_fees( tx, _remote_db->get_global_properties().parameters.current_fees );
      set_operation_fees( tx, current_fees );
      vector<public_key_type> paying_keys = registrar_account_object.active.get_keys();
@ -3496,7 +3494,7 @@ public:
      new_fees.scale = scale;
      chain_parameters new_params = current_params;
-      new_params.current_fees = new_fees;
+      new_params.current_fees = std::make_shared<fee_schedule>(new_fees);
      committee_member_update_global_parameters_operation update_op;
      update_op.new_parameters = new_params;
--- a/programs/build_helpers/member_enumerator.cpp
+++ b/programs/build_helpers/member_enumerator.cpp
@ -28,7 +28,6 @@
 #include <graphene/chain/account_object.hpp>
 #include <graphene/chain/balance_object.hpp>
 #include <graphene/chain/committee_member_object.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <iostream>
 using namespace graphene::chain;
--- a/programs/cli_wallet/main.cpp
+++ b/programs/cli_wallet/main.cpp
@ -34,7 +34,6 @@
 #include <fc/rpc/cli.hpp>
 #include <fc/rpc/http_api.hpp>
 #include <fc/rpc/websocket_api.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/app/api.hpp>
 #include <graphene/chain/config.hpp>
--- a/programs/genesis_util/genesis_update.cpp
+++ b/programs/genesis_util/genesis_update.cpp
@ -30,7 +30,6 @@
 #include <fc/io/fstream.hpp>
 #include <fc/io/json.hpp>
 #include <fc/io/stdio.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/app/api.hpp>
 #include <graphene/chain/protocol/address.hpp>
--- a/programs/js_operation_serializer/main.cpp
+++ b/programs/js_operation_serializer/main.cpp
@ -55,7 +55,6 @@
 #include <graphene/chain/sidechain_address_object.hpp>
 #include <graphene/chain/sidechain_transaction_object.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <iostream>
 using namespace graphene::chain;
@ -128,7 +127,6 @@ struct js_name<fc::array<T,N>>
 template<size_t N>   struct js_name<fc::array<char,N>>    { static std::string name(){ return  "bytes "+ fc::to_string(N); }; };
 template<size_t N>   struct js_name<fc::array<uint8_t,N>> { static std::string name(){ return  "bytes "+ fc::to_string(N); }; };
 template<typename T> struct js_name< fc::optional<T> >    { static std::string name(){ return "optional " + js_name<T>::name(); } };
 template<typename T> struct js_name< fc::smart_ref<T> >   { static std::string name(){ return js_name<T>::name(); } };
 template<>           struct js_name< object_id_type >     { static std::string name(){ return "object_id_type"; } };
 template<typename T> struct js_name< fc::flat_set<T> >    { static std::string name(){ return "set " + js_name<T>::name(); } };
 template<typename T> struct js_name< std::vector<T> >     { static std::string name(){ return "array " + js_name<T>::name(); } };
@ -256,14 +254,6 @@ struct serializer<std::vector<T>,false>
   static void generate() {}
 };
 template<typename T>
 struct serializer<fc::smart_ref<T>,false>
 {
   static void init() { 
      serializer<T>::init(); }
   static void generate() {}
 };
 template<>
 struct serializer<std::vector<operation>,false>
 {
--- a/programs/size_checker/main.cpp
+++ b/programs/size_checker/main.cpp
@ -23,7 +23,6 @@
 */
 #include <fc/io/json.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <fc/variant.hpp>
 #include <fc/variant_object.hpp>
--- a/tests/app/main.cpp
+++ b/tests/app/main.cpp
@ -35,7 +35,6 @@
 #include <graphene/affiliate_stats/affiliate_stats_plugin.hpp>
 #include <graphene/market_history/market_history_plugin.hpp>
 #include <fc/thread/thread.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <boost/filesystem/path.hpp>
--- a/tests/benchmarks/genesis_allocation.cpp
+++ b/tests/benchmarks/genesis_allocation.cpp
@ -26,7 +26,6 @@
 #include <graphene/utilities/tempdir.hpp>
 #include <fc/crypto/digest.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <boost/test/auto_unit_test.hpp>
--- a/tests/betting/betting_tests.cpp
+++ b/tests/betting/betting_tests.cpp
@ -1877,10 +1877,11 @@ BOOST_AUTO_TEST_CASE(event_group_delete_test_not_existed_event_group)
    try
    {
        CREATE_ICE_HOCKEY_BETTING_MARKET(false, 0);
 	event_group_id_type nhl_id = nhl.id;
 	delete_event_group(nhl_id);
        delete_event_group(nhl.id);
-        BOOST_CHECK_THROW(delete_event_group(nhl.id), fc::exception);
+        BOOST_CHECK_THROW(delete_event_group(nhl_id), fc::exception);
    } FC_LOG_AND_RETHROW()
 }
--- a/tests/cli/cli_fixture.cpp
+++ b/tests/cli/cli_fixture.cpp
@ -12,7 +12,6 @@
 #include <fc/crypto/base58.hpp>
 #include <fc/crypto/aes.hpp>
 #include <fc/smart_ref_impl.hpp>
 #ifdef _WIN32
 #ifndef _WIN32_WINNT
--- a/tests/cli/main.cpp
+++ b/tests/cli/main.cpp
@ -24,7 +24,6 @@
 #include "cli_fixture.hpp"
 #include <fc/crypto/aes.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/utilities/tempdir.hpp>
--- a/tests/cli/son.cpp
+++ b/tests/cli/son.cpp
@ -23,7 +23,6 @@
 */
 #include "cli_fixture.hpp"
 #include <fc/smart_ref_impl.hpp>
 #include <fc/string.hpp>
 #include <boost/test/unit_test.hpp>
--- a/tests/common/database_fixture.cpp
+++ b/tests/common/database_fixture.cpp
@ -48,7 +48,6 @@
 #include <graphene/utilities/tempdir.hpp>
 #include <fc/crypto/digest.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <exception>
 #include <iostream>
@ -712,7 +711,7 @@ void database_fixture::change_fees(
      new_fees.scale = new_scale;
   chain_parameters new_chain_params = current_chain_params;
-   new_chain_params.current_fees = new_fees;
+   new_chain_params.current_fees = std::make_shared<fee_schedule>(new_fees);
   db.modify(db.get_global_properties(), [&](global_property_object& p) {
      p.parameters = new_chain_params;
@ -1039,7 +1038,7 @@ void database_fixture::enable_fees()
 {
   db.modify(global_property_id_type()(db), [](global_property_object& gpo)
   {
-      gpo.parameters.current_fees = fee_schedule::get_default();
+      gpo.parameters.current_fees = std::make_shared<fee_schedule>(fee_schedule::get_default());
   });
 }
--- a/tests/common/database_fixture.hpp
+++ b/tests/common/database_fixture.hpp
@ -26,7 +26,6 @@
 #include <graphene/app/application.hpp>
 #include <graphene/chain/database.hpp>
 #include <fc/io/json.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/chain/operation_history_object.hpp>
--- a/tests/generate_empty_blocks/main.cpp
+++ b/tests/generate_empty_blocks/main.cpp
@ -30,7 +30,6 @@
 #include <fc/io/fstream.hpp>
 #include <fc/io/json.hpp>
 #include <fc/io/stdio.hpp>
 #include <fc/smart_ref_impl.hpp>
 #include <graphene/app/api.hpp>
 #include <graphene/chain/protocol/protocol.hpp>
--- a/tests/tests/fee_tests.cpp
+++ b/tests/tests/fee_tests.cpp
@ -22,7 +22,6 @@
 * THE SOFTWARE.
 */
 #include <fc/smart_ref_impl.hpp>
 #include <fc/uint128.hpp>
 #include <graphene/chain/hardfork.hpp>
@ -334,7 +333,7 @@ BOOST_AUTO_TEST_CASE( cashback_test )
   upgrade_to_lifetime_member(rog_id);
   BOOST_TEST_MESSAGE("Enable fees");
-   const auto& fees = db.get_global_properties().parameters.current_fees;
+   const auto& fees = *db.get_global_properties().parameters.current_fees;
 #define CustomRegisterActor(actor_name, registrar_name, referrer_name, referrer_rate) \
   { \
@ -346,7 +345,7 @@ BOOST_AUTO_TEST_CASE( cashback_test )
      op.options.memo_key = actor_name ## _private_key.get_public_key(); \
      op.active = authority(1, public_key_type(actor_name ## _private_key.get_public_key()), 1); \
      op.owner = op.active; \
-      op.fee = fees->calculate_fee(op); \
+      op.fee = fees.calculate_fee(op); \
      trx.operations = {op}; \
      sign( trx,  registrar_name ## _private_key ); \
      actor_name ## _id = PUSH_TX( db, trx ).operation_results.front().get<object_id_type>(); \
@ -372,10 +371,10 @@ BOOST_AUTO_TEST_CASE( cashback_test )
      CustomAuditActor( pleb );                      \
   }
-   int64_t reg_fee    = fees->get< account_create_operation >().premium_fee;
+   int64_t reg_fee    = fees.get< account_create_operation >().premium_fee;
-   int64_t xfer_fee   = fees->get< transfer_operation >().fee;
+   int64_t xfer_fee   = fees.get< transfer_operation >().fee;
-   int64_t upg_an_fee = fees->get< account_upgrade_operation >().membership_annual_fee;
+   int64_t upg_an_fee = fees.get< account_upgrade_operation >().membership_annual_fee;
-   int64_t upg_lt_fee = fees->get< account_upgrade_operation >().membership_lifetime_fee;
+   int64_t upg_lt_fee = fees.get< account_upgrade_operation >().membership_lifetime_fee;
   // all percentages here are cut from whole pie!
   uint64_t network_pct = 20 * P1;
   uint64_t lt_pct = 375 * P100 / 1000;
@ -582,7 +581,7 @@ BOOST_AUTO_TEST_CASE( account_create_fee_scaling )
   auto accounts_per_scale = db.get_global_properties().parameters.accounts_per_fee_scale;
   db.modify(global_property_id_type()(db), [](global_property_object& gpo)
   {
-      gpo.parameters.current_fees = fee_schedule::get_default();
+      gpo.parameters.current_fees = std::make_shared<fee_schedule>(fee_schedule::get_default());
      gpo.parameters.current_fees->get<account_create_operation>().basic_fee = 1;
   });
@ -1004,8 +1003,9 @@ BOOST_AUTO_TEST_CASE( issue_429_test )
      // make sure the database requires our fee to be nonzero
      enable_fees();
-      auto fees_to_pay = db.get_global_properties().parameters.current_fees->get<asset_create_operation>();
+      const auto& fees = *db.get_global_properties().parameters.current_fees;
-
+      auto fees_to_pay = fees.get<asset_create_operation>();
      {
         signed_transaction tx;
         asset_create_operation op;
--- a/tests/tests/history_api_tests.cpp
+++ b/tests/tests/history_api_tests.cpp
@ -30,7 +30,6 @@
 #include "../common/database_fixture.hpp"
 #include <fc/smart_ref_impl.hpp>
 #include <fc/crypto/digest.hpp>
 using namespace graphene::app;